[webkit-reviews] review granted: [Bug 236062] Setup a custom URL scheme for PDF.js resources : [Attachment 451533] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 236062: Setup a custom URL scheme for PDF.js resources
https://bugs.webkit.org/show_bug.cgi?id=236062

Attachment 451533: Patch

https://bugs.webkit.org/attachment.cgi?id=451533&action=review




--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 451533
  --> https://bugs.webkit.org/attachment.cgi?id=451533
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451533&action=review

> Source/WebCore/ChangeLog:11
> +	   https://bugs.webkit.org/show_bug.cgi?id=235981 takes care of
populating this folder at build-time.

Please update change log according latest patch.

> Source/WebKit/ChangeLog:8
> +	   The code handling the scheme is under WebCore::PDFJSResourceLoader.

Ditto.

> Source/WebCore/loader/ResourceLoader.h:162
> +    WEBCORE_EXPORT bool isPDFJSResourceLoad() const;

Could be #if PLATFORM(COCOA)?