[webkit-reviews] review granted: [Bug 236436] [GTK][WPE] Improve device detection in the GbmDevice : [Attachment 451514] Patch

[bugzilla-daemon at webkit.org]

Chris Lord <clord at igalia.com> has granted  review:
Bug 236436: [GTK][WPE] Improve device detection in the GbmDevice
https://bugs.webkit.org/show_bug.cgi?id=236436

Attachment 451514: Patch

https://bugs.webkit.org/attachment.cgi?id=451514&action=review




--- Comment #4 from Chris Lord <clord at igalia.com> ---
Comment on attachment 451514
  --> https://bugs.webkit.org/attachment.cgi?id=451514
Patch

> > Source/WebCore/platform/graphics/gbm/GBMDevice.cpp:74
> > +	 memset(devices, 0, sizeof(drmDevicePtr) * 64);
> 
> This * 64 is incorrect, sizeof(drmDevicePtr) should be correct on its own.

Whoops, we just spoke about this and I wanted to add here - I misread this and
what's there is fine, but `sizeof(devices)` along with the other suggested
change would make this patch more robust. Changing my r- to an r+ to reflect
that mistake.