[webkit-reviews] review granted: [Bug 236437] [GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and fix some issues : [Attachment 451513] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 10 05:46:20 PST 2022


Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 236437: [GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and
fix some issues
https://bugs.webkit.org/show_bug.cgi?id=236437

Attachment 451513: Patch

https://bugs.webkit.org/attachment.cgi?id=451513&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 451513
  --> https://bugs.webkit.org/attachment.cgi?id=451513
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451513&action=review

> Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:785
> +    int bwrapFd = argumentsToFileDescriptor(sandboxArgs, "bwrap");

Much better function name, indeed!


More information about the webkit-reviews mailing list