[webkit-reviews] review granted: [Bug 233018] WebKit should pipe mouse hover events on iOS to the UI delegate : [Attachment 451480] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 9 23:15:49 PST 2022


Tim Horton <thorton at apple.com> has granted Kevin Turner
<kevin_turner at apple.com>'s request for review:
Bug 233018: WebKit should pipe mouse hover events on iOS to the UI delegate
https://bugs.webkit.org/show_bug.cgi?id=233018

Attachment 451480: Patch

https://bugs.webkit.org/attachment.cgi?id=451480&action=review




--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 451480
  --> https://bugs.webkit.org/attachment.cgi?id=451480
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451480&action=review

> Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h:28
> +#if TARGET_OS_OSX || TARGET_OS_IPHONE

I'm pretty sure this condition is true everywhere that this file exists (IPHONE
includes all of the iOS-derivatives), so maybe you can just delete it instead?
Or maybe you meant TARGET_OS_IOS

> Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:74
> +#if !PLATFORM(MAC)

Why the inverted condition? Should be PLATFORM(IOS_FAMILY) or maybe the HAVE


More information about the webkit-reviews mailing list