[webkit-reviews] review granted: [Bug 236419] Fail synchronously when constructing a SharedWorker with an URL that is not same-origin : [Attachment 451467] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 236419: Fail synchronously when constructing a SharedWorker with an URL
that is not same-origin
https://bugs.webkit.org/show_bug.cgi?id=236419

Attachment 451467: Patch

https://bugs.webkit.org/attachment.cgi?id=451467&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 451467
  --> https://bugs.webkit.org/attachment.cgi?id=451467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451467&action=review

> LayoutTests/imported/w3c/ChangeLog:16
> +	   *
web-platform-tests/workers/shared-worker-in-data-url-context.window-expected.tx
t:
> +	   Even though this looks like a regression, this actually aligns our
behavior with both
> +	   Blink & Gecko (who also fail this check). Note that the load fails
no matter what.
> +	   However, the test expects it to fail asynchronously instead of
synchronously in this
> +	   case.

When will we fix WPT?