[webkit-reviews] review granted: [Bug 236405] Mail attachment switched to TIFF and balloons in size after markup. : [Attachment 451455] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 236405: Mail attachment switched to TIFF and balloons in size after markup.
https://bugs.webkit.org/show_bug.cgi?id=236405

Attachment 451455: Patch

https://bugs.webkit.org/attachment.cgi?id=451455&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 451455
  --> https://bugs.webkit.org/attachment.cgi?id=451455
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451455&action=review

> Source/WebKit/UIProcess/API/APIAttachment.cpp:106
> +NSData* Attachment::enclosingImageNSData() const

Nit - * is still on the wrong side here.

> Source/WebKit/UIProcess/API/APIAttachment.cpp:108
> +    return nullptr;

Nit - `return nil;`