[webkit-reviews] review granted: [Bug 235758] [GPU Process] Move ImageBuffer::createCompatibleImageBuffer() and SVGRenderingContext::createImageBuffer to GraphicsContext : [Attachment 451341] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 235758: [GPU Process] Move ImageBuffer::createCompatibleImageBuffer() and
SVGRenderingContext::createImageBuffer to GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=235758

Attachment 451341: Patch

https://bugs.webkit.org/attachment.cgi?id=451341&action=review




--- Comment #22 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 451341
  --> https://bugs.webkit.org/attachment.cgi?id=451341
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451341&action=review

> Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:70
> +    // Ignore 2D rotation, as it doesn't affect the size of the mask.
> +    FloatSize scale(absoluteTransform.xScale(), absoluteTransform.yScale());
> +
> +    // Determine scale factor for the clipper. The size of intermediate
ImageBuffers shouldn't be bigger than kMaxFilterSize.
> +    ImageBuffer::sizeNeedsClamping(repaintRect.size(), scale);
> +
> +    auto maskImage = context->createImageBuffer(repaintRect, scale);

There's a bit of repeated code here; I wonder if it should be moved into a
helper method.

> Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:482
> +    auto renderingMode = renderingMethod == RenderingMethod::Default ?
this->renderingMode() : RenderingMode::Unaccelerated;

This implicit impact of renderingMethod on renderingMode is a bit subtle.