[webkit-reviews] review granted: [Bug 236261] Incorrect abspos layout when toggling contain : [Attachment 451279] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 236261: Incorrect abspos layout when toggling contain
https://bugs.webkit.org/show_bug.cgi?id=236261

Attachment 451279: Patch

https://bugs.webkit.org/attachment.cgi?id=451279&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 451279
  --> https://bugs.webkit.org/attachment.cgi?id=451279
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451279&action=review

> Source/WebCore/rendering/RenderBlock.cpp:381
> +    if (oldStyle.position() == newStyle.position() && hadTransform ==
willHaveTransform && (hadLayoutContainment == willHaveLayoutContainment))

No need for the last pair of parens.

> Source/WebCore/rendering/RenderBlock.cpp:387
> +	   outOfFlowDescendantsHaveNewContainingBlock = hadLayoutContainment &&
!willHaveLayoutContainment;

I can't figure out why it's hadLayoutContainment && !willHaveLayoutContainment
and not also !hadLayoutContainment && willHaveLayoutContainment

>
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-layout-020.
html:38
> +  window.requestAnimationFrame( () => {

No space before () unless this is WPT style. I'd drop 'window.' too