[webkit-reviews] review granted: [Bug 236355] Allow hanging run-javascriptcore-tests to print backtrace : [Attachment 451350] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Angelos Oikonomopoulos
<angelos at igalia.com>'s request for review:
Bug 236355: Allow hanging run-javascriptcore-tests to print backtrace
https://bugs.webkit.org/show_bug.cgi?id=236355

Attachment 451350: Patch

https://bugs.webkit.org/attachment.cgi?id=451350&action=review




--- Comment #4 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 451350
  --> https://bugs.webkit.org/attachment.cgi?id=451350
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451350&action=review

> Tools/CISupport/build-webkit-org/steps.py:467
> +	   if 'sigtermTime' not in kwargs:

Not sure if you had specific reason for guarding with this if condition, could
have skipped if condition as well. Either way is fine though.