[webkit-reviews] review granted: [Bug 236054] Add support for parsing 'subgrid' in grid-template-columns/row : [Attachment 451281] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Matt Woodrow
<mattwoodrow at apple.com>'s request for review:
Bug 236054: Add support for parsing 'subgrid' in grid-template-columns/row
https://bugs.webkit.org/show_bug.cgi?id=236054

Attachment 451281: Patch

https://bugs.webkit.org/attachment.cgi?id=451281&action=review




--- Comment #22 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 451281
  --> https://bugs.webkit.org/attachment.cgi?id=451281
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451281&action=review

Thanks for working on this, everyone is waiting for subgrid support.

Also thanks for adding more WPT test cases.

I've just left a few minor comments.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1040
> +	   // TODO: We need to handle computed subgrid here.

NIt: In WebKit it's more common FIXME than TODO.

> Source/WebCore/css/parser/CSSPropertyParser.cpp:3679
> +static bool consumeGridNameRepeatFunction(CSSParserTokenRange& range,
CSSValueList& list, bool& isAutoRepeat)

If I got it correctly, this is only used for subgrid, should we change the name
so it's more clear that it's only for that?

> LayoutTests/TestExpectations:1470
>
+imported/w3c/web-platform-tests/css/css-grid/subgrid/grid-subgridded-axis-auto
-repeater-crash-001.html [ Crash ]
>
+imported/w3c/web-platform-tests/css/css-grid/subgrid/grid-subgridded-axis-auto
-repeater-crash-002.html [ Crash ]

I guess we do want to fix these crashes ASAP, do you have a bug report to track
them?