[webkit-reviews] review requested: [Bug 235924] Web Inspector: [Flexbox] Show flex badge next to flex containers in DOM Tree : [Attachment 451344] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has asked  for review:
Bug 235924: Web Inspector: [Flexbox] Show flex badge next to flex containers in
DOM Tree
https://bugs.webkit.org/show_bug.cgi?id=235924

Attachment 451344: Patch

https://bugs.webkit.org/attachment.cgi?id=451344&action=review




--- Comment #4 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 451344

  --> https://bugs.webkit.org/attachment.cgi?id=451344&action=review

Patch

Fixed the bug when all flexbox overlays used the same pink color.

The patch has a lot of straightforward changes to OverlayManager.js. Most
grid-related methods and variables now have their flex counterparts, e.g.
showGridOverlay/showFlexOverlay.
This doesn't change the existing grid logic, which is good. The downside is
that now we have a fair amount of code duplication. It's tempting to refactor
this, but I don't think it's a good idea for the next 7 days.