[webkit-reviews] review granted: [Bug 236109] [Cocoa] Adopt -streamDataParser:didProvideContentKeySpecifier:forTrackID: delegate callback : [Attachment 451270] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 236109: [Cocoa] Adopt
-streamDataParser:didProvideContentKeySpecifier:forTrackID: delegate callback
https://bugs.webkit.org/show_bug.cgi?id=236109

Attachment 451270: Patch

https://bugs.webkit.org/attachment.cgi?id=451270&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 451270
  --> https://bugs.webkit.org/attachment.cgi?id=451270
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451270&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:66
> +    PlatformSample::Type platformSampleType() const override { return
PlatformSample::CMSampleBufferType; }

final

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:1251
> +	   return;

Worth ASSERTing in a debug build?

> Tools/ChangeLog:15
> +2022-02-07  Jer Noble  <jer.noble at apple.com>
> +
> +	   [Cocoa] Adopt
-streamDataParser:didProvideContentKeySpecifier:forTrackID: delegate callback
> +	   https://bugs.webkit.org/show_bug.cgi?id=236109
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Cocoa] Adopt
-streamDataParser:didProvideContentKeySpecifier:forTrackID: delegate callback
> +	   https://bugs.webkit.org/show_bug.cgi?id=236109
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Source/WebCore:
> +
> +	   The current set of delegate callback methods have a significant
shortcoming: clients must

This is in the wrong file