[webkit-reviews] review granted: [Bug 236245] Add settings to restrict media containers and codecs when in Captive Portal mode : [Attachment 451271] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 236245: Add settings to restrict media containers and codecs when in
Captive Portal mode
https://bugs.webkit.org/show_bug.cgi?id=236245

Attachment 451271: Patch

https://bugs.webkit.org/attachment.cgi?id=451271&action=review




--- Comment #11 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 451271
  --> https://bugs.webkit.org/attachment.cgi?id=451271
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451271&action=review

> Source/WTF/ChangeLog:134
> +2022-02-07  Jer Noble  <jer.noble at apple.com>
> +
> +	   Add settings to restrict media containers and codecs when in Captive
Portal mode
> +	   https://bugs.webkit.org/show_bug.cgi?id=236245
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * Scripts/Preferences/WebPreferences.yaml:
> +

Nit: move this to the top of the ChangeLog

> LayoutTests/media/video-test.js:243
> +    return waitFor(element, type, false, true);

s/false, true/false, false/