[webkit-reviews] review granted: [Bug 236151] [WebAuthn] Use AuthenticationServicesAgent for WebAuthn calls on iOS : [Attachment 450930] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 236151: [WebAuthn] Use AuthenticationServicesAgent for WebAuthn calls on
iOS
https://bugs.webkit.org/show_bug.cgi?id=236151

Attachment 450930: Patch

https://bugs.webkit.org/attachment.cgi?id=450930&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 450930
  --> https://bugs.webkit.org/attachment.cgi?id=450930
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450930&action=review

r=me

>
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProx
y.mm:313
> +    [proxy.get() performAuthorizationRequestsForContext:requestContext.get()
withCompletionHandler:makeBlockPtr([handler = WTFMove(handler), proxy =
WTFMove(proxy)](id <ASCCredentialProtocol> credential, NSError *error) mutable
{

Nit: I don't think you need to 'get()' on proxy when calling a method like this
(though you *do* need to call 'get()' when you want to pass a pointer.