[webkit-reviews] review granted: [Bug 236308] [LFC][Integration] LineIteratorModernPath::baselineType should consult Display::Line : [Attachment 451261] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 8 09:55:48 PST 2022


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 236308: [LFC][Integration] LineIteratorModernPath::baselineType should
consult Display::Line
https://bugs.webkit.org/show_bug.cgi?id=236308

Attachment 451261: Patch

https://bugs.webkit.org/attachment.cgi?id=451261&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 451261
  --> https://bugs.webkit.org/attachment.cgi?id=451261
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451261&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLine.h:39
> +    Line(size_t firstBoxIndex, size_t boxCount, const FloatRect&
lineBoxRect, float enclosingContentTop, float enclosingContentBottom, const
FloatRect& scrollableOverflow, const FloatRect& inkOverflow, float baseline,
FontBaseline baselineType, float contentLeft, float contentLogicalWidth)

OMG we still have this


More information about the webkit-reviews mailing list