[webkit-reviews] review granted: [Bug 236262] [JSC] Convert JSString's non-atomic WTF::String to atomic string while concurrent compilers / heap threads run : [Attachment 451156] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 236262: [JSC] Convert JSString's non-atomic WTF::String to atomic string
while concurrent compilers / heap threads run
https://bugs.webkit.org/show_bug.cgi?id=236262

Attachment 451156: Patch

https://bugs.webkit.org/attachment.cgi?id=451156&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 451156
  --> https://bugs.webkit.org/attachment.cgi?id=451156
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451156&action=review

r=me

>>> Source/JavaScriptCore/ChangeLog:8
>>> +	     Inspired from Cameron's change. This patch introduces a new
protocol which allows us to replace JSString's underlying non-atomic String
>> 
>> Which change are you referring to here (I don't know, and in the future
those reading this surely will not know).
> 
> This one https://trac.webkit.org/changeset/289177/webkit.

I'd link it here in the changelog or just write r289177