[webkit-reviews] review denied: [Bug 236263] http/tests/cache-storage/cache-origins.https.html is flaky : [Attachment 451157] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 236263: http/tests/cache-storage/cache-origins.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=236263

Attachment 451157: Patch

https://bugs.webkit.org/attachment.cgi?id=451157&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 451157
  --> https://bugs.webkit.org/attachment.cgi?id=451157
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451157&action=review

We should do this sorting inside WebCore, I think.

> LayoutTests/http/tests/cache-storage/cache-origins.https.html:23
> +	   representation.sort((a, b) => { return a.origin.clientOrigin >
b.origin.clientOrigin; });

This isn’t right. It’s supposed to be a three way sort function, and needs to
return -1, 0, +1 based on the ordering. Not like C++ standard library where
they used boolean less than style sorting.

> LayoutTests/http/tests/cache-storage/cache-origins.https.html:36
> +	   representation.sort((a, b) => { return a.origin.clientOrigin >
b.origin.clientOrigin; });

Ditto.