[webkit-reviews] review granted: [Bug 236249] Update hover state based on pointer type. : [Attachment 451138] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 236249: Update hover state based on pointer type.
https://bugs.webkit.org/show_bug.cgi?id=236249

Attachment 451138: Patch

https://bugs.webkit.org/attachment.cgi?id=451138&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 451138
  --> https://bugs.webkit.org/attachment.cgi?id=451138
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451138&action=review

> Source/WebCore/dom/Element.h:346
> +    virtual void setHovered(bool = true, Style::InvalidationScope =
Style::InvalidationScope::All, HitTestRequest = HitTestRequest());

{ }

> Source/WebCore/html/HTMLTextFormControlElement.cpp:73
> +    UNUSED_PARAM(request);

can just drop the argument names instead of UNUSED_PARAM (applies in a bunch of
places)

> Source/WebCore/html/HTMLTextFormControlElement.cpp:128
> +    // Update our status first.

Do not think this comment is necessary (maybe if it said why, but since it
doesn't, get rid of it).

> Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:148
> +- (bool)checkTouches:(NSSet<UITouch *> *)touches

Don't think you need this anymore?