[webkit-reviews] review requested: [Bug 236013] Web Inspector: [Flexbox] Add support for showing/hiding flex container overlays and basic overlay drawing : [Attachment 451132] Patch 1.1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 7 11:57:34 PST 2022
Razvan Caliman <rcaliman at apple.com> has asked for review:
Bug 236013: Web Inspector: [Flexbox] Add support for showing/hiding flex
container overlays and basic overlay drawing
https://bugs.webkit.org/show_bug.cgi?id=236013
Attachment 451132: Patch 1.1
https://bugs.webkit.org/attachment.cgi?id=451132&action=review
--- Comment #10 from Razvan Caliman <rcaliman at apple.com> ---
Created attachment 451132
--> https://bugs.webkit.org/attachment.cgi?id=451132&action=review
Patch 1.1
Address code review:
- simplified test
- renamed flexContainerQuad to containerBounds
- replaced renderFlex.absoluteBoundingBoxRectIgnoringTransforms() with
renderFlex.absoluteBoundingBoxRectIgnoringTransforms()
- addressed nits
More information about the webkit-reviews
mailing list