[webkit-reviews] review granted: [Bug 235857] Add PushService : [Attachment 451008] rebase

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Ben Nham <nham at apple.com>'s
request for review:
Bug 235857: Add PushService
https://bugs.webkit.org/show_bug.cgi?id=235857

Attachment 451008: rebase

https://bugs.webkit.org/attachment.cgi?id=451008&action=review




--- Comment #8 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 451008
  --> https://bugs.webkit.org/attachment.cgi?id=451008
rebase

View in context: https://bugs.webkit.org/attachment.cgi?id=451008&action=review

> Source/WebKit/Shared/Cocoa/WebPushMessageCocoa.mm:43
> +    BOOL isNull = pushData == [NSNull null];

You can find example of both in our code base, but it's much more proper to do:
[pushData isEqual:[NSNull null]];