[webkit-reviews] review granted: [Bug 236100] Add PageClient plumbing for video frame extraction : [Attachment 451116] Rebase on trunk

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 236100: Add PageClient plumbing for video frame extraction
https://bugs.webkit.org/show_bug.cgi?id=236100

Attachment 451116: Rebase on trunk

https://bugs.webkit.org/attachment.cgi?id=451116&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 451116
  --> https://bugs.webkit.org/attachment.cgi?id=451116
Rebase on trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=451116&action=review

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:511
> +	   if (RetainPtr controller =
protectedThis->m_videoFullscreenManager->playerViewController(identifier))

You null-checked m_videoFullscreenManager before the completion handler, but is
it guaranteed to still be valid here?