[webkit-reviews] review granted: [Bug 236166] AX: Move node-dependent role computation to AccessibilityNodeObject from AccessibilityRenderObject : [Attachment 450988] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 7 09:21:36 PST 2022


chris fleizach <cfleizach at apple.com> has granted  review:
Bug 236166: AX: Move node-dependent role computation to AccessibilityNodeObject
from AccessibilityRenderObject
https://bugs.webkit.org/show_bug.cgi?id=236166

Attachment 450988: Patch

https://bugs.webkit.org/attachment.cgi?id=450988&action=review




--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 450988
  --> https://bugs.webkit.org/attachment.cgi?id=450988
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450988&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:256
> +	   HTMLSelectElement& selectElement =
downcast<HTMLSelectElement>(*node());

can probably use auto& here


More information about the webkit-reviews mailing list