[webkit-reviews] review granted: [Bug 236170] Tidy up some ImageBuffer-related classes : [Attachment 450991] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 6 15:21:32 PST 2022


Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 236170: Tidy up some ImageBuffer-related classes
https://bugs.webkit.org/show_bug.cgi?id=236170

Attachment 450991: Patch

https://bugs.webkit.org/attachment.cgi?id=450991&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 450991
  --> https://bugs.webkit.org/attachment.cgi?id=450991
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450991&action=review

> Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.h:49
> +    GraphicsContext& context() const final;

Could consider also making these private if they are always called
polymorphically, on the ImageBufferCGBackend base class.


More information about the webkit-reviews mailing list