[webkit-reviews] review granted: [Bug 236180] [WTF] Make Bitmap constexpr friendly : [Attachment 451026] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 6 10:45:19 PST 2022
Darin Adler <darin at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 236180: [WTF] Make Bitmap constexpr friendly
https://bugs.webkit.org/show_bug.cgi?id=236180
Attachment 451026: Patch
https://bugs.webkit.org/attachment.cgi?id=451026&action=review
--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 451026
--> https://bugs.webkit.org/attachment.cgi?id=451026
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=451026&action=review
> Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:547
> + static constexpr Bitmap<256> doNotUnescapeWhenDecodingURI =
makeCharacterBitmap(
I would have written auto in these places instead of repeating the type.
More information about the webkit-reviews
mailing list