[webkit-reviews] review granted: [Bug 236181] [WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in CompletionHandler.h : [Attachment 450996] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 5 20:16:10 PST 2022


Yusuke Suzuki <ysuzuki at apple.com> has granted  review:
Bug 236181: [WTF] Fix clang tidy bugprone-move-forwarding-reference static
analyzer warnings in CompletionHandler.h
https://bugs.webkit.org/show_bug.cgi?id=236181

Attachment 450996: Patch v2

https://bugs.webkit.org/attachment.cgi?id=450996&action=review




--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 450996
  --> https://bugs.webkit.org/attachment.cgi?id=450996
Patch v2

r=me, yes, it can be a lref or rref (b/c CallableType is template type of this
function), thus we should use std::forward.


More information about the webkit-reviews mailing list