[webkit-reviews] review granted: [Bug 236177] [LFC][IFC] Add initial ideographic baseline support : [Attachment 450983] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 236177: [LFC][IFC] Add initial ideographic baseline support
https://bugs.webkit.org/show_bug.cgi?id=236177

Attachment 450983: Patch

https://bugs.webkit.org/attachment.cgi?id=450983&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 450983
  --> https://bugs.webkit.org/attachment.cgi?id=450983
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450983&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:207
> +    InlineLayoutUnit ascent = fontMetrics.ascent(useIdeographicBaseline ?
IdeographicBaseline : AlphabeticBaseline);
> +    InlineLayoutUnit descent = fontMetrics.descent(useIdeographicBaseline ?
IdeographicBaseline : AlphabeticBaseline);

Maybe this code could just use the existing FontBaseline enum everywhere
(though it should be enum class)?

> Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h:52
> +    enum class UseIdeographicBaseline : uint8_t { No, Yes };

Replacing this too.