[webkit-reviews] review denied: [Bug 236073] ch unit fallback size doesn't match the spec : [Attachment 450959] WIP

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has denied  review:
Bug 236073: ch unit fallback size doesn't match the spec
https://bugs.webkit.org/show_bug.cgi?id=236073

Attachment 450959: WIP

https://bugs.webkit.org/attachment.cgi?id=450959&action=review




--- Comment #4 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 450959
  --> https://bugs.webkit.org/attachment.cgi?id=450959
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=450959&action=review

> Source/WebCore/platform/graphics/Font.cpp:154
> -    m_fontMetrics.setZeroWidth(widthForGlyph(zeroGlyph));
> +    m_fontMetrics.setZeroWidth(zeroGlyph ? widthForGlyph(zeroGlyph) :
platformData().size() / 2);

I guess this isn't a great fix because it isn't ch-specific.