[webkit-reviews] review granted: [Bug 234578] Grid may be empty in certain scenarios : [Attachment 450932] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 4 15:20:53 PST 2022


Darin Adler <darin at apple.com> has granted Brandon <brandonstewart at apple.com>'s
request for review:
Bug 234578: Grid may be empty in certain scenarios
https://bugs.webkit.org/show_bug.cgi?id=234578

Attachment 450932: Patch

https://bugs.webkit.org/attachment.cgi?id=450932&action=review




--- Comment #23 from Darin Adler <darin at apple.com> ---
Comment on attachment 450932
  --> https://bugs.webkit.org/attachment.cgi?id=450932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450932&action=review

> Source/WebCore/rendering/RenderGrid.cpp:191
> +    Vector<RenderBox*> aspectRatioBlockSizeDependentGridItems;

I don’t think our local vector needs such a long name.


More information about the webkit-reviews mailing list