[webkit-reviews] review granted: [Bug 236139] RealtimeOutgoingVideoSourceCocoa rotation session should not use IOSurface : [Attachment 450892] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 236139: RealtimeOutgoingVideoSourceCocoa rotation session should not use
IOSurface
https://bugs.webkit.org/show_bug.cgi?id=236139

Attachment 450892: Patch

https://bugs.webkit.org/attachment.cgi?id=450892&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 450892
  --> https://bugs.webkit.org/attachment.cgi?id=450892
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450892&action=review

> Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.mm:102
> +	   auto bufferPool = m_shouldUseIOSurface ?
createIOSurfaceCVPixelBufferPool(m_rotatedSize.width(), m_rotatedSize.height(),
m_pixelFormat, 0u, m_isCGImageCompatible == IsCGImageCompatible::Yes) :
createInMemoryCVPixelBufferPool(m_rotatedSize.width(), m_rotatedSize.height(),
m_pixelFormat, 0u, m_isCGImageCompatible == IsCGImageCompatible::Yes);

Nit: this is long enough that I think it would be easier to read and understand
as an `if ... else`