[webkit-reviews] review granted: [Bug 236132] LibWebRTCCodecs SharedVideoFrameWriters can deadlock in case of GPUProcess crash : [Attachment 450883] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 236132: LibWebRTCCodecs SharedVideoFrameWriters can deadlock in case of
GPUProcess crash
https://bugs.webkit.org/show_bug.cgi?id=236132

Attachment 450883: Patch

https://bugs.webkit.org/attachment.cgi?id=450883&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 450883
  --> https://bugs.webkit.org/attachment.cgi?id=450883
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450883&action=review

> Source/WebKit/ChangeLog:10
> +	   To prevent this, whenever we detect a GPUProcess connection, we
disable SharedVideoFrameWriters, which has the effect of

Do you mean whenever we detect a GPUProcess *crash*?

> Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp:45
> +    fprintf(stderr, "SharedVideoFrameWriter::wait\n");

Oops!

> LayoutTests/webrtc/vp8-then-h264-gpu-process-crash.html:91
> +}, "Frames should be coming event after gpu process crash");

a/event/even/