[webkit-reviews] review granted: [Bug 223536] Crash in DocumentLoader::urlForHistory : [Attachment 450901] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 4 09:01:37 PST 2022


Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 223536: Crash in DocumentLoader::urlForHistory
https://bugs.webkit.org/show_bug.cgi?id=223536

Attachment 450901: Patch

https://bugs.webkit.org/attachment.cgi?id=450901&action=review




--- Comment #25 from Darin Adler <darin at apple.com> ---
Comment on attachment 450901
  --> https://bugs.webkit.org/attachment.cgi?id=450901
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450901&action=review

> Source/WebCore/loader/FrameLoader.cpp:1830
> +    m_inStopForBackForwardCache = true;

Can this function be re-re-entered? Should we add an assertion or early return
for that case?


More information about the webkit-reviews mailing list