[webkit-reviews] review requested: [Bug 233949] [WTF] RELEASE_ASSERT_WITH_MESSAGE() should always print the message : [Attachment 450903] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has asked  for review:
Bug 233949: [WTF] RELEASE_ASSERT_WITH_MESSAGE() should always print the message
https://bugs.webkit.org/show_bug.cgi?id=233949

Attachment 450903: Patch

https://bugs.webkit.org/attachment.cgi?id=450903&action=review




--- Comment #21 from Adrian Perez <aperez at igalia.com> ---
Created attachment 450903

  --> https://bugs.webkit.org/attachment.cgi?id=450903&action=review

Patch


Here goes one more iteration. This makes it possible to use
RELEASE_ASSERT_WITH_MESSAGE() without format strings (and in
that case it prints only the failed condition of the assertion)
and that way it can be used to replace the local redefinitions
of RELEASE_ASSERT from the JSC files that had them—where the
intention seemed to be that a message of some kind is always
desired even in release builds.

Let me know what do you think of this approach. If you think we
can further simplify, I will be happy to massage the patch a bit
more =)