[webkit-reviews] review granted: [Bug 235490] [Flatpak SDK] Extension points for the Flatpak Sparkle-CDM extension : [Attachment 449751] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 235490: [Flatpak SDK] Extension points for the Flatpak Sparkle-CDM
extension
https://bugs.webkit.org/show_bug.cgi?id=235490

Attachment 449751: Patch

https://bugs.webkit.org/attachment.cgi?id=449751&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 449751
  --> https://bugs.webkit.org/attachment.cgi?id=449751
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449751&action=review

> Tools/buildstream/elements/flatpak/platform.bst:84
> +	 no-autodownload: 'true'

What's the reason to quote the booleans? They could as well be specified
directly as they are valid YAML values:

  autodelete: False
  no-autodownload: True

I know that there are many other instances around which are strings, but
the man page for fltpak-metadata clearly states that these fields are
indeed booleans (not strings). Probably this has been working fine because
when saving the data back when building the image the writer that is
serializing the values by chance chooses to write the strings unquoted
(which is allowed in YAML) and the parser from the Flatpak tooling is
magnanimous enough to accept the lowercase unquoted “true“ and “false“
strings as booleans.

Or am I overthinking things here? Anyway, we know the current approach
works and I am mostly wondering what's going on in reality.