[webkit-reviews] review granted: [Bug 235694] [GTK] Crash when starting DND on touchscreen : [Attachment 450630] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 235694: [GTK] Crash when starting DND on touchscreen
https://bugs.webkit.org/show_bug.cgi?id=235694

Attachment 450630: Patch

https://bugs.webkit.org/attachment.cgi?id=450630&action=review




--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 450630
  --> https://bugs.webkit.org/attachment.cgi?id=450630
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450630&action=review

LGTM

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1936
> +    webkitWebViewBaseSynthesizeMouseEvent(webViewBase,
MouseEventType::Motion, 0, 0, x, y, modifiers, nPress, mousePointerEventType(),
true);
> +    webkitWebViewBaseSynthesizeMouseEvent(webViewBase,
MouseEventType::Press, button, 0, x, y, modifiers, nPress,
mousePointerEventType(), true);
> +    webkitWebViewBaseSynthesizeMouseEvent(webViewBase,
MouseEventType::Release, button, buttons, x, y, modifiers, nPress,
mousePointerEventType(), true);

This would be easier to read using an enum class instead of a boolean,
PlatformMouseEvent::IsTouch::Yes, for example.