[webkit-reviews] review granted: [Bug 236111] Fix App Privacy Report redirect attribution : [Attachment 450841] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 236111: Fix App Privacy Report redirect attribution
https://bugs.webkit.org/show_bug.cgi?id=236111

Attachment 450841: Patch

https://bugs.webkit.org/attachment.cgi?id=450841&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 450841
  --> https://bugs.webkit.org/attachment.cgi?id=450841
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450841&action=review

And a test! I think this looks great, once you correct the ChangeLog. Thank you
for jumping on this so quickly!

> Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp:372
>      auto oldInspectorInitiatorNodeIdentifier =
inspectorInitiatorNodeIdentifier();

I think this is right, but I also suggest we clean up the constructors for
CFNet and NSURLRequest.it may not fix anything, but I believe it is bad to ever
have our WebKit flag out of sync with the NSURLRequest item.

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:-624
> -#endif

Wry nice to simplify this!