[webkit-reviews] review granted: [Bug 235993] Delete SelectionAcrossShadowBoundariesEnabled : [Attachment 450832] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 3 16:37:33 PST 2022


Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 235993: Delete SelectionAcrossShadowBoundariesEnabled
https://bugs.webkit.org/show_bug.cgi?id=235993

Attachment 450832: Patch

https://bugs.webkit.org/attachment.cgi?id=450832&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 450832
  --> https://bugs.webkit.org/attachment.cgi?id=450832
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450832&action=review

> Source/WebCore/editing/Editor.cpp:3313
> +    return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText
} | TextIteratorBehavior::TraversesFlatTree);

Should use commas here instead:

    return selectedText({ TextIteratorBehavior::EmitsImageAltText,
TextIteratorBehavior::TraversesFlatTree });


More information about the webkit-reviews mailing list