[webkit-reviews] review granted: [Bug 235944] [Forms] Alias appearance <compat-auto> keywords to 'auto' : [Attachment 450744] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 3 14:15:42 PST 2022


Aditya Keerthi <akeerthi at apple.com> has granted zsun at igalia.com's request for
review:
Bug 235944: [Forms] Alias appearance <compat-auto> keywords to 'auto'
https://bugs.webkit.org/show_bug.cgi?id=235944

Attachment 450744: Patch

https://bugs.webkit.org/attachment.cgi?id=450744&action=review




--- Comment #4 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 450744
  --> https://bugs.webkit.org/attachment.cgi?id=450744
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450744&action=review

> Source/WebCore/rendering/RenderTheme.cpp:90
> +    if (!element)

Nit: The early return here can be moved before the declaration/assignment of
`part`.

> Source/WebCore/rendering/RenderTheme.h:469
> +    ControlPart adjustAppearanceWithElementType(RenderStyle&, const
Element*) const;

Consider renaming this to `adjustAppearanceForElement`, since it doesn't take
an "element type".


More information about the webkit-reviews mailing list