[webkit-reviews] review granted: [Bug 236039] Implement AbortSignal.timeout() : [Attachment 450771] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 236039: Implement AbortSignal.timeout()
https://bugs.webkit.org/show_bug.cgi?id=236039

Attachment 450771: Patch

https://bugs.webkit.org/attachment.cgi?id=450771&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 450771
  --> https://bugs.webkit.org/attachment.cgi?id=450771
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450771&action=review

> Source/WebCore/dom/AbortSignal.cpp:65
> +	   auto* globalObject = context.globalObject();

We should do the jsCast here, not wait until below to do it:

    auto* globalObject = jsCast<JSDOMGlobalObject*>(context.globalObject());

But also, and this is the patch I am working on, ScriptExecutionContext’s
globalObject function should return JSDOMGlobalObject* or JSDOMGlobalObject&.