[webkit-reviews] review denied: [Bug 234578] Grid may be empty in certain scenarios : [Attachment 450712] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 3 04:57:57 PST 2022
Darin Adler <darin at apple.com> has denied Brandon <brandonstewart at apple.com>'s
request for review:
Bug 234578: Grid may be empty in certain scenarios
https://bugs.webkit.org/show_bug.cgi?id=234578
Attachment 450712: Patch
https://bugs.webkit.org/attachment.cgi?id=450712&action=review
--- Comment #16 from Darin Adler <darin at apple.com> ---
Comment on attachment 450712
--> https://bugs.webkit.org/attachment.cgi?id=450712
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=450712&action=review
>> Source/WebCore/ChangeLog:3
>> + Grid may be empty in certain scenarios
>
> Why no new tests and no change in test results?
Let me say this more clearly.:WebKit patches that change behavior must include
regression tests covering the improvement. Please submit a new patch that
includes a test.
More information about the webkit-reviews
mailing list