[webkit-reviews] review granted: [Bug 229398] Incorrect KeyframesEffect generated for background : [Attachment 450754] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 3 03:39:14 PST 2022


Darin Adler <darin at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 229398: Incorrect KeyframesEffect generated for background
https://bugs.webkit.org/show_bug.cgi?id=229398

Attachment 450754: Patch

https://bugs.webkit.org/attachment.cgi?id=450754&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 450754
  --> https://bugs.webkit.org/attachment.cgi?id=450754
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450754&action=review

> Source/WebCore/animation/KeyframeEffect.cpp:402
> +	      
previousKeyframe.style->mergeAndOverrideOnConflict(keyframe.style.get());

Might not need that get()


More information about the webkit-reviews mailing list