[webkit-reviews] review granted: [Bug 236039] Implement AbortSignal.timeout() : [Attachment 450704] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 2 18:36:08 PST 2022


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 236039: Implement AbortSignal.timeout()
https://bugs.webkit.org/show_bug.cgi?id=236039

Attachment 450704: Patch

https://bugs.webkit.org/attachment.cgi?id=450704&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 450704
  --> https://bugs.webkit.org/attachment.cgi?id=450704
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450704&action=review

> Source/WebCore/dom/AbortSignal.cpp:135
> +    auto* context = scriptExecutionContext();
> +    if (!context || context->activeDOMObjectsAreStopped())
> +	   return;
> +
> +    auto* globalObject = wrapper() ? wrapper()->globalObject() : nullptr;
> +    if (!globalObject)
> +	   return;
> +
> +    auto& vm = globalObject->vm();
> +    Locker locker { vm.apiLock() };
> +    signalAbort(toJS(globalObject, globalObject,
DOMException::create(TimeoutError)));

Annoying we have to write so much custom binding code for this.


More information about the webkit-reviews mailing list