[webkit-reviews] review denied: [Bug 215379] Implement HTTPServer for API tests in c++ : [Attachment 450596] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Takashi Komori
<takashi.komori at sony.com>'s request for review:
Bug 215379: Implement HTTPServer for API tests in c++
https://bugs.webkit.org/show_bug.cgi?id=215379

Attachment 450596: Patch

https://bugs.webkit.org/attachment.cgi?id=450596&action=review




--- Comment #21 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 450596
  --> https://bugs.webkit.org/attachment.cgi?id=450596
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450596&action=review

> Tools/TestWebKitAPI/HTTPServer.cpp:253
> +Vector<uint8_t> HTTPResponse::serialize(IncludeContentLength
includeContentLength) const

This still has duplicate code instead of nice abstractions that have
platform-specific implementations.