[webkit-reviews] review granted: [Bug 236038] Move connect event dispatch logic to SharedWorkerGlobalScope : [Attachment 450696] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 236038: Move connect event dispatch logic to SharedWorkerGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=236038

Attachment 450696: Patch

https://bugs.webkit.org/attachment.cgi?id=450696&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 450696
  --> https://bugs.webkit.org/attachment.cgi?id=450696
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450696&action=review

> Source/WebCore/workers/shared/SharedWorkerGlobalScope.cpp:68
> +    auto serializedScriptValue = SerializedScriptValue::create("");

emptyString()?

Shorter variable name? Maybe serializedValue or even just value?

> Source/WebCore/workers/shared/SharedWorkerGlobalScope.h:28
> +#include "MessageWithMessagePorts.h"

Do we really need this header? No way to forward declare TransferredMessagePort
instead?