[webkit-reviews] review granted: [Bug 235991] Adjust some Live Text code to only use VKC-prefixed VisionKit classes if ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS) : [Attachment 450597] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 2 09:41:42 PST 2022
Megan Gardner <megan_gardner at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 235991: Adjust some Live Text code to only use VKC-prefixed VisionKit
classes if ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS)
https://bugs.webkit.org/show_bug.cgi?id=235991
Attachment 450597: Patch
https://bugs.webkit.org/attachment.cgi?id=450597&action=review
--- Comment #2 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 450597
--> https://bugs.webkit.org/attachment.cgi?id=450597
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=450597&action=review
> Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h:57
> +RetainPtr<CocoaImageAnalyzerRequest> createImageAnalyzerRequest(CGImageRef,
VKAnalysisTypes);
Is VKAnalysisTypes not also getting replaced?
More information about the webkit-reviews
mailing list