[webkit-reviews] review granted: [Bug 236017] Move SharedWorkerThread & SharedWorkerProxy to workers/shared/context/ : [Attachment 450646] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 236017: Move SharedWorkerThread & SharedWorkerProxy to
workers/shared/context/
https://bugs.webkit.org/show_bug.cgi?id=236017

Attachment 450646: Patch

https://bugs.webkit.org/attachment.cgi?id=450646&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 450646
  --> https://bugs.webkit.org/attachment.cgi?id=450646
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450646&action=review

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp:112
> +    m_scriptExecutionContext->postTask([this] (ScriptExecutionContext&) {

s/ScriptExecutionContext/auto/.
Are we sure this is valid?
Maybe add a comment stating why.

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:40
> +class SharedWorkerThreadProxy : public
ThreadSafeRefCounted<SharedWorkerThreadProxy>, public WorkerGlobalScopeProxy,
public WorkerObjectProxy, public WorkerLoaderProxy, public WorkerDebuggerProxy
{

final?

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:65
> +    void setResourceCachingDisabledByWebInspector(bool) final;

Can they be made private?

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:68
> +    SharedWorkerThreadProxy(SharedWorker&);

explicit.