[webkit-reviews] review granted: [Bug 235953] MediaRecorderPrivate should not need to create IOSurfaces : [Attachment 450641] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 235953: MediaRecorderPrivate should not need to create IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=235953

Attachment 450641: Patch

https://bugs.webkit.org/attachment.cgi?id=450641&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 450641
  --> https://bugs.webkit.org/attachment.cgi?id=450641
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450641&action=review

> Source/WebKit/ChangeLog:13
>	   * WebProcess/cocoa/UserMediaCaptureManager.cpp:
>  
> +2022-02-01  Youenn Fablet  <youenn at apple.com>

This doesn't look right

> Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp:95
> +	   if (!pixelBuffer)
> +	       return;

Is it worth logging an error message?

> Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:110
> +	   if (!copySharedVideoFrame(remoteSample->imageBuffer()))
> +	       return;

Ditto