[webkit-reviews] review granted: [Bug 236016] Move and rename ServiceWorkerFrameLoaderClient & ServiceWorkerLibWebRTCProvider : [Attachment 450644] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 2 08:19:25 PST 2022


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 236016: Move and rename ServiceWorkerFrameLoaderClient &
ServiceWorkerLibWebRTCProvider
https://bugs.webkit.org/show_bug.cgi?id=236016

Attachment 450644: Patch

https://bugs.webkit.org/attachment.cgi?id=450644&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 450644
  --> https://bugs.webkit.org/attachment.cgi?id=450644
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450644&action=review

> Source/WebCore/loader/FrameLoaderClient.h:354
> +    virtual bool isWebWorkerFrameLoaderClient() const { return false; }

Not sure WebWorker is a great name given DedicatedWorker would seem to fit
there.
Not sure I have a better name though, maybe RemoteWorker.


More information about the webkit-reviews mailing list