[webkit-reviews] review granted: [Bug 235925] [Modules] ES module link errors should be reported unmuted from script elements : [Attachment 450488] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Asumu Takikawa
<asumu at igalia.com>'s request for review:
Bug 235925: [Modules] ES module link errors should be reported unmuted from
script elements
https://bugs.webkit.org/show_bug.cgi?id=235925

Attachment 450488: Patch

https://bugs.webkit.org/attachment.cgi?id=450488&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 450488
  --> https://bugs.webkit.org/attachment.cgi?id=450488
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450488&action=review

r=me

> Source/WebCore/bindings/js/ScriptController.cpp:215
> +	   reportException(&lexicalGlobalObject, evaluationException, nullptr,
/* fromModule */ true);

I recommend using a boolean variable here to name it.

constexpr bool fromModule = true;
reportException(&lexicalGlobalObject, evaluationException, nullptr,
fromModule);