[webkit-reviews] review canceled: [Bug 236002] Rename FontCascade::spaceWidth() to FontCascade::spaceWidthOfPrimaryFont() : [Attachment 450612] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 1 23:00:25 PST 2022
Myles C. Maxfield <mmaxfield at apple.com> has canceled Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 236002: Rename FontCascade::spaceWidth() to
FontCascade::spaceWidthOfPrimaryFont()
https://bugs.webkit.org/show_bug.cgi?id=236002
Attachment 450612: Patch
https://bugs.webkit.org/attachment.cgi?id=450612&action=review
--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 450612
--> https://bugs.webkit.org/attachment.cgi?id=450612
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=450612&action=review
> Source/WebCore/platform/graphics/FontCascade.h:167
> + float spaceWidthOfPrimaryFont() const { return
primaryFont().spaceWidth() + m_letterSpacing; }
This probably isn't a great name, because it includes letter spacing.
More information about the webkit-reviews
mailing list