[webkit-reviews] review granted: [Bug 235607] No breakpoints hit on github.com, and some are invalid : [Attachment 450502] Patch v1.2 - Pass parser-xml-close-comment.html again

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 1 17:43:05 PST 2022


Yusuke Suzuki <ysuzuki at apple.com> has granted Patrick Angle
<pangle at apple.com>'s request for review:
Bug 235607: No breakpoints hit on github.com, and some are invalid
https://bugs.webkit.org/show_bug.cgi?id=235607

Attachment 450502: Patch v1.2 - Pass parser-xml-close-comment.html again

https://bugs.webkit.org/attachment.cgi?id=450502&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 450502
  --> https://bugs.webkit.org/attachment.cgi?id=450502
Patch v1.2 - Pass parser-xml-close-comment.html again

View in context: https://bugs.webkit.org/attachment.cgi?id=450502&action=review

r=me

> Source/JavaScriptCore/parser/Lexer.cpp:2493
>	   }

I know it is pre-existing, but this }'s place is wrong, so can you unindent one
level?


More information about the webkit-reviews mailing list